FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.1

Threshold is Low

Effort is Max

Summary

Classes Bugs Errors Missing Classes
600 83 0 0

Files

Class Bugs
fr.inria.opengve.mascoptLib.gui.AutoArrangeGraphs$MyVector 1
fr.inria.opengve.mascoptLib.gui.MascoptChooser.Filter 2
fr.inria.opengve.mascoptLib.gui.MascoptChooser.MascoptChooser 3
fr.inria.opengve.mascoptLib.gui.ThemeManager 1
fr.inria.opengve.mascoptLib.gui.editor.Editor 10
fr.inria.opengve.mascoptLib.gui.editor.ViewWindowListener 1
fr.inria.opengve.mascoptLib.gui.editor.ViewsEditorListener 2
fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui 7
fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$3 1
fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$8 2
fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$PrettyPrintableMethod 1
fr.inria.opengve.mascoptLib.gui.layerManager.DefaultEventListener 1
fr.inria.opengve.mascoptLib.gui.layerManager.GEdge 2
fr.inria.opengve.mascoptLib.gui.layerManager.GFlow 1
fr.inria.opengve.mascoptLib.gui.layerManager.GGraph 2
fr.inria.opengve.mascoptLib.gui.layerManager.GLabel 2
fr.inria.opengve.mascoptLib.gui.layerManager.GLayer 1
fr.inria.opengve.mascoptLib.gui.layerManager.GObject 2
fr.inria.opengve.mascoptLib.gui.layerManager.GPath 2
fr.inria.opengve.mascoptLib.gui.layerManager.GVertex 5
fr.inria.opengve.mascoptLib.gui.layerManager.GView 1
fr.inria.opengve.mascoptLib.gui.layerManager.Layer 1
fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager 4
fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager$LabelConfiguration 1
fr.inria.opengve.mascoptLib.gui.layerManager.Link 6
fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager 10
fr.inria.opengve.mascoptLib.gui.mapEditor.MapEditor 3
fr.inria.opengve.mascoptLib.gui.stepAlgoGui.StepAlgoGui 2
fr.inria.opengve.mascoptLib.gui.stepAlgoGui.StepAlgoGui$WindowsConfiguration 1
fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser 2
fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$1 1
fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$2 1
fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$ValuesChooserEntry 1

fr.inria.opengve.mascoptLib.gui.AutoArrangeGraphs$MyVector

Bug Category Details Line
Should fr.inria.opengve.mascoptLib.gui.AutoArrangeGraphs$MyVector be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 190-241

fr.inria.opengve.mascoptLib.gui.MascoptChooser.Filter

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 141
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 123

fr.inria.opengve.mascoptLib.gui.MascoptChooser.MascoptChooser

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.MascoptChooser.MascoptChooser.getDiGraph(Reader, String) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 342
fr.inria.opengve.mascoptLib.gui.MascoptChooser.MascoptChooser.getGraph(Reader, String) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 298
fr.inria.opengve.mascoptLib.gui.MascoptChooser.MascoptChooser.getMap(Reader, String) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 187

fr.inria.opengve.mascoptLib.gui.ThemeManager

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.ThemeManager.setTheme(String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 51

fr.inria.opengve.mascoptLib.gui.editor.Editor

Bug Category Details Line
Impossible cast from fr.inria.opengve.mascoptLib.core.MascoptAbstractGraph to fr.inria.opengve.mascoptLib.core.MascoptAbstractPath in fr.inria.opengve.mascoptLib.gui.editor.Editor.computeMiddle(MascoptObject) CORRECTNESS BC_IMPOSSIBLE_CAST 1192
fr.inria.opengve.mascoptLib.gui.editor.Editor.killEditor() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 1908
Exception is caught when Exception is not thrown in fr.inria.opengve.mascoptLib.gui.editor.Editor.loadFile(String) STYLE REC_CATCH_EXCEPTION 1504
Class fr.inria.opengve.mascoptLib.gui.editor.Editor defines non-transient non-serializable instance field autoArrangeThread BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.editor.Editor defines non-transient non-serializable instance field currentContext BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.editor.Editor defines non-transient non-serializable instance field currentMap BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.editor.Editor defines non-transient non-serializable instance field el BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.editor.Editor defines non-transient non-serializable instance field layer BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.editor.Editor defines non-transient non-serializable instance field layerManager BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.editor.Editor defines non-transient non-serializable instance field objectEdited BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.editor.ViewWindowListener

Bug Category Details Line
Unread field: fr.inria.opengve.mascoptLib.gui.editor.ViewWindowListener.associatedGView PERFORMANCE URF_UNREAD_FIELD 32

fr.inria.opengve.mascoptLib.gui.editor.ViewsEditorListener

Bug Category Details Line
Redundant nullcheck of fr.inria.opengve.mascoptLib.gui.editor.ViewsEditorListener.ag, which is known to be non-null in fr.inria.opengve.mascoptLib.gui.editor.ViewsEditorListener.destroyOperation(MascoptObject) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 171
Redundant nullcheck of fr.inria.opengve.mascoptLib.gui.editor.ViewsEditorListener.ag, which is known to be non-null in fr.inria.opengve.mascoptLib.gui.editor.ViewsEditorListener.destroyOperation(MascoptObject) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 177

fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui

Bug Category Details Line
Method fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui.htmlProprietyOfGraph(MascoptAbstractGraph, boolean) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 1535
Class fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui defines non-transient non-serializable instance field fileReader_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui defines non-transient non-serializable instance field graph_ BAD_PRACTICE SE_BAD_FIELD Not available
Unread field: fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui.add; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 173
Unread field: fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui.addRemove; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 177
Unread field: fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui.remove; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 175
Method fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui.htmlProprietyOfGraph(MascoptAbstractGraph, boolean) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1533

fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$3

Bug Category Details Line
Exception is caught when Exception is not thrown in fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$3.actionPerformed(ActionEvent) STYLE REC_CATCH_EXCEPTION 680

fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$8

Bug Category Details Line
Dead store to computator in fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$8.actionPerformed(ActionEvent) STYLE DLS_DEAD_LOCAL_STORE 1098
Comparison of String objects using == or != in fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$8.actionPerformed(ActionEvent) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 1072

fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$PrettyPrintableMethod

Bug Category Details Line
The method name fr.inria.opengve.mascoptLib.gui.graphgenerator.GeneratorGui$PrettyPrintableMethod.GenerateSet(Class) doesn't start with an lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 1593-1599

fr.inria.opengve.mascoptLib.gui.layerManager.DefaultEventListener

Bug Category Details Line
Redundant nullcheck of fr.inria.opengve.mascoptLib.gui.layerManager.DefaultEventListener.movingDraggedEdge_, which is known to be non-null in fr.inria.opengve.mascoptLib.gui.layerManager.DefaultEventListener.mouseReleased(MouseEvent) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 121

fr.inria.opengve.mascoptLib.gui.layerManager.GEdge

Bug Category Details Line
Class fr.inria.opengve.mascoptLib.gui.layerManager.GEdge defines non-transient non-serializable instance field gGraph_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.GEdge defines non-transient non-serializable instance field mascoptLink_ BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.layerManager.GFlow

Bug Category Details Line
Class fr.inria.opengve.mascoptLib.gui.layerManager.GFlow implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 32-148

fr.inria.opengve.mascoptLib.gui.layerManager.GGraph

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.layerManager.GGraph.finalize() does nothing except call super.finalize(); delete it BAD_PRACTICE FI_USELESS 259-260
Class fr.inria.opengve.mascoptLib.gui.layerManager.GGraph implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 22-260

fr.inria.opengve.mascoptLib.gui.layerManager.GLabel

Bug Category Details Line
Method fr.inria.opengve.mascoptLib.gui.layerManager.GLabel.toString() concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 233
Class fr.inria.opengve.mascoptLib.gui.layerManager.GLabel defines non-transient non-serializable instance field labelListener_ BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.layerManager.GLayer

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.layerManager.GLayer.finalize() does nothing except call super.finalize(); delete it BAD_PRACTICE FI_USELESS 383-384

fr.inria.opengve.mascoptLib.gui.layerManager.GObject

Bug Category Details Line
Unchecked/unconfirmed cast from fr.inria.opengve.mascoptLib.gui.layerManager.Layer to fr.inria.opengve.mascoptLib.gui.layerManager.GLayer in fr.inria.opengve.mascoptLib.gui.layerManager.GObject.setLayer(Layer) STYLE BC_UNCONFIRMED_CAST 61
Class fr.inria.opengve.mascoptLib.gui.layerManager.GObject defines non-transient non-serializable instance field layer_ BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.layerManager.GPath

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.layerManager.GPath.finalize() does nothing except call super.finalize(); delete it BAD_PRACTICE FI_USELESS 259-260
Class fr.inria.opengve.mascoptLib.gui.layerManager.GPath implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 22-260

fr.inria.opengve.mascoptLib.gui.layerManager.GVertex

Bug Category Details Line
Class fr.inria.opengve.mascoptLib.gui.layerManager.GVertex defines non-transient non-serializable instance field gGraph BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.GVertex defines non-transient non-serializable instance field image BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.GVertex defines non-transient non-serializable instance field imageOff BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.GVertex defines non-transient non-serializable instance field imageOn BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.GVertex defines non-transient non-serializable instance field node BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.layerManager.GView

Bug Category Details Line
Class fr.inria.opengve.mascoptLib.gui.layerManager.GView defines non-transient non-serializable instance field background BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.layerManager.Layer

Bug Category Details Line
Method fr.inria.opengve.mascoptLib.gui.layerManager.Layer.moveUnderEverything(GObject) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 117

fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager.newLayer(String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 279
fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager.setLayerUpdateLabelsWhenValuesChange(GLayer, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 1149
Redundant nullcheck of gGraph, which is known to be non-null in fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager.setGraphLinkWidth(MascoptObject, GLayer, int) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 1185
Unread field: fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager.DEFAULT_VISIBLE_LABEL; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 22

fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager$LabelConfiguration

Bug Category Details Line
Should fr.inria.opengve.mascoptLib.gui.layerManager.LayerManager$LabelConfiguration be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 121-124

fr.inria.opengve.mascoptLib.gui.layerManager.Link

Bug Category Details Line
Class fr.inria.opengve.mascoptLib.gui.layerManager.Link defines non-transient non-serializable instance field curve_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.Link defines non-transient non-serializable instance field insideCurve_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.Link defines non-transient non-serializable instance field insideLoop_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.Link defines non-transient non-serializable instance field linkListener_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.Link defines non-transient non-serializable instance field loop_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.layerManager.Link defines non-transient non-serializable instance field picture_ BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager

Bug Category Details Line
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.getClosestShiftAndRemove(Vector, double) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 195
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.getFreeShift(GVertex, GVertex) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 378
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.getFreeShift(GVertex, GVertex) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 386
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.setEdgeShift(GEdge, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 219
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.setEdgeShift(GEdge, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 220
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.setEdgeShift(GEdge, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 225
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.setEdgeShift(GEdge, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 227
Method fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.setShiftFree(GVertex, GVertex, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 356
Unread field: fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.initialShift_; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 35
Unread field: fr.inria.opengve.mascoptLib.gui.layerManager.LinkManager.stepShift_; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 40

fr.inria.opengve.mascoptLib.gui.mapEditor.MapEditor

Bug Category Details Line
Class fr.inria.opengve.mascoptLib.gui.mapEditor.MapEditor defines non-transient non-serializable instance field editedMap_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.mapEditor.MapEditor defines non-transient non-serializable instance field valueChangeContext_ BAD_PRACTICE SE_BAD_FIELD Not available
Class fr.inria.opengve.mascoptLib.gui.mapEditor.MapEditor defines non-transient non-serializable instance field valueChangeKey_ BAD_PRACTICE SE_BAD_FIELD Not available

fr.inria.opengve.mascoptLib.gui.stepAlgoGui.StepAlgoGui

Bug Category Details Line
Unchecked/unconfirmed cast from fr.inria.opengve.mascoptLib.core.MascoptObservableObject to fr.inria.opengve.mascoptLib.core.MascoptMap in fr.inria.opengve.mascoptLib.gui.stepAlgoGui.StepAlgoGui.update(MascoptObservableObject, MascoptNotification) STYLE BC_UNCONFIRMED_CAST 556
Method fr.inria.opengve.mascoptLib.gui.stepAlgoGui.StepAlgoGui.saveWindowsToImage() concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 210

fr.inria.opengve.mascoptLib.gui.stepAlgoGui.StepAlgoGui$WindowsConfiguration

Bug Category Details Line
Should fr.inria.opengve.mascoptLib.gui.stepAlgoGui.StepAlgoGui$WindowsConfiguration be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 122-137

fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser

Bug Category Details Line
Class fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser defines non-transient non-serializable instance field condVar BAD_PRACTICE SE_BAD_FIELD Not available
Condition.await() not in loop in fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser.choose() MT_CORRECTNESS WA_AWAIT_NOT_IN_LOOP 413

fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$1

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$1.mouseClicked(MouseEvent) does not release lock on all exception paths MT_CORRECTNESS UL_UNRELEASED_LOCK_EXCEPTION_PATH 534

fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$2

Bug Category Details Line
fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$2.mouseClicked(MouseEvent) does not release lock on all exception paths MT_CORRECTNESS UL_UNRELEASED_LOCK_EXCEPTION_PATH 556

fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$ValuesChooserEntry

Bug Category Details Line
Should fr.inria.opengve.mascoptLib.gui.valuesChooser.ValuesChooser$ValuesChooserEntry be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 88-305